Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the zero check in RawVec::grow. #72366

Merged
merged 1 commit into from
May 20, 2020

Conversation

nnethercote
Copy link
Contributor

This was supposed to land as part of #72227. (I wish git push would
abort when you have uncommited changes.)

r? @Amanieu

This was supposed to land as part of rust-lang#72227. (I wish `git push` would
abort when you have uncommited changes.)
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 20, 2020
@Amanieu
Copy link
Member

Amanieu commented May 20, 2020

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 20, 2020

📌 Commit 9eb0399 has been approved by Amanieu

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 20, 2020
@RalfJung
Copy link
Member

(I wish git push would abort when you have uncommited changes.)

FWIW, I find it really helpful for my shell to indicate the git status to me in the prompt -- makes such mistakes much less likely. There are tons of scripts for that purpose out there. I use this one.

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 20, 2020
…owup, r=Amanieu

Adjust the zero check in `RawVec::grow`.

This was supposed to land as part of rust-lang#72227. (I wish `git push` would
abort when you have uncommited changes.)

r? @Amanieu
bors added a commit to rust-lang-ci/rust that referenced this pull request May 20, 2020
Rollup of 6 pull requests

Successful merges:

 - rust-lang#71863 (Suggest fixes and add error recovery for `use foo::self`)
 - rust-lang#72139 (Make `fold` standalone.)
 - rust-lang#72275 (Continue lowering for unsupported async generator instead of returning an error.)
 - rust-lang#72361 (split_inclusive: add tracking issue number (72360))
 - rust-lang#72364 (Remove unused dependencies)
 - rust-lang#72366 (Adjust the zero check in `RawVec::grow`.)

Failed merges:

r? @ghost
@bors bors merged commit 51f80b7 into rust-lang:master May 20, 2020
@nnethercote nnethercote deleted the tiny-vecs-are-dumb-followup branch May 21, 2020 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants